Repository navigation
reimplement: PathFindingState methods that are 100% - #266
Merged
Merged
Conversation
TheRedDaemon
self-requested a review
October 15, 2026 20:27
TheRedDaemon
requested changes
Oct 15, 2026
TheRedDaemon
requested changes
Oct 15, 2026
Bring the twelve PathFindingState .cpp files that already match the original binary to the style used on main, and verify every one of them still matches: - drop the decompiler's comment blocks (decompilerscript, WARNING: Enum) and the duplicate include of the file's own .func.hpp - clearActiveClimbDataOfType6And7: the two lockstep pointers over climbData become a counted for loop over named fields, the trailing return goes - clearPathFindingTileMaps: sizeof(layer) instead of 0x27420/0x13a10, and the layer passed straight through instead of (void*)((int)(...)) - computeAttackVectorsBasedOnXAndY: iVar1/_index named, += 1 instead of x = x + 1, 80400 instead of 0x13a10, de-yoda'd bound test - reflow the clearActiveClimbDataOfType6And7 doc comment reccmp before and after: all twelve at 100.0%, normalized 100.0%. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
gynt
commented
Oct 17, 2026
gynt
commented
Oct 17, 2026
TheRedDaemon
previously approved these changes
Oct 18, 2026
TheRedDaemon
self-requested a review
October 18, 2026 21:45
TheRedDaemon
requested changes
Oct 18, 2026
Revert the 102 unrelated percentage/status updates in status/addresses-SHC-3BB0A8C1.txt back to main, keeping only the four addresses whose .cpp files are added or modified in this branch. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
gynt
force-pushed
the
reimpl/PathFindingState-100
branch
from
October 18, 2026 21:56
545002b to
037fa05
Compare
TheRedDaemon
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
100% matching but currently not always styled properly yet.